Add a dev doc for resuming SDG runs #136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the design for how we plan to resume interrupted SDG runs. Signed-off-by: Ben Browning <[email protected]>
Signed-off-by: Ben Browning <[email protected]>
Signed-off-by: Ben Browning <[email protected]>
bbrowning
force-pushed
the
sdg-resume
branch
from
e6b3d88
to
d9cca57
Compare
Signed-off-by: Ben Browning <[email protected]>
Signed-off-by: Ben Browning <[email protected]>
danmcp
reviewed
Sep 23, 2024
|
|
||
| ## Non-Goals | ||
|
|
||
| This is not replacing checkpoints. Checkpoints are how we save each |
There was a problem hiding this comment.
It might be helpful to give the context of how long a batch might take for comparison.
There was a problem hiding this comment.
Yes, that's a good idea. And I also need to talk about how checkpoints persist across individual data generation runs, while this is focused on the ability to resume a specific interrupted SDG run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the design for how we plan to resume interrupted SDG runs.